Fix CI for #453: clang-format and type stubs for channel conversion#472
Open
gijzelaerr wants to merge 4 commits intospotify:masterfrom
Open
Fix CI for #453: clang-format and type stubs for channel conversion#472gijzelaerr wants to merge 4 commits intospotify:masterfrom
gijzelaerr wants to merge 4 commits intospotify:masterfrom
Conversation
Fixes CI failures from psobot's spotify#453 (channel conversion feature): - Apply clang-format (LLVM style) to ReadableAudioFile.h, ChannelConvertedReadableAudioFile.h, and python_bindings.cpp - Add ChannelConvertedReadableAudioFile class to type stubs - Add mono(), stereo(), with_channels() method stubs to ReadableAudioFile, ResampledReadableAudioFile, and ChannelConvertedReadableAudioFile - Add resampled_to() method stubs to ResampledReadableAudioFile and ChannelConvertedReadableAudioFile (inherited from abstract base) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on @psobot's #453 (
.mono()/.stereo()/.with_channels()channel conversion methods) and fixes the two CI failures:clang-format --style=LLVMtoReadableAudioFile.h,ChannelConvertedReadableAudioFile.h, andpython_bindings.cppChannelConvertedReadableAudioFileclass definition andmono(),stereo(),with_channels()method stubs toReadableAudioFile,ResampledReadableAudioFile, andChannelConvertedReadableAudioFileinpedalboard_native/io/__init__.pyiTest plan
ChannelConvertedReadableAudioFilefor.mono()support when reading files. #453 continue to pass🤖 Generated with Claude Code